binderName is Async when binder.Name ends with Async

[vjacquet]

OrchardCore/src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultShapeFactory.cs

Lines 39 to 42 in 9a76299

	if (binderName.EndsWith("Async", StringComparison.Ordinal))
	{
	binderName = binder.Name[^"Async".Length..];
	}

Unless I am mistaken, the intent of the code is to trim the Async suffix, yet it does the opposite, keeping only the Async

var binderName = "TestAsync";
if (binderName.EndsWith("Async", StringComparison.Ordinal))
{
    binderName = binderName[^"Async".Length..];
    Debug.Assert(binderName != "Async", "binderName is set to Async");
}

Line 41 should be

    binderName = binderName[..^"Async".Length];

[hishamco]

You are right, could you please send a PR