Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL Issues #14483

Closed
hishamco opened this issue Oct 11, 2023 · 3 comments · Fixed by #14486
Closed

RTL Issues #14483

hishamco opened this issue Oct 11, 2023 · 3 comments · Fixed by #14486
Labels
bug 🐛
Milestone
1.8

Comments

@hishamco
Copy link
Member

After the last update in Bootstrap I noticed there were many things broken in RTL especially, did we test before merging it?

I'm not sure if CSS classes were added inline intentionally or for a purpose because all know the classes that affect the language direction is matter

/cc @agriffard @MikeAlhayek @Skrypt
@hishamco
Copy link
Member Author

I will struggle to fix as much as I can

@Skrypt
Copy link
Contributor

Skrypt commented Oct 11, 2023 •
edited
Loading

They probably forgot to test RTL if it is broken. At least it is on the dev branch and will require to be fixed before releasing any new version. Releasing a regression is never good.

@hishamco
Copy link
Member Author

@MikeAlhayek could you please recheck if I missed something on my end

@MikeAlhayek MikeAlhayek mentioned this issue Oct 11, 2023
Merged
@MikeAlhayek MikeAlhayek added this to the 1.x milestone Nov 3, 2023
@MikeAlhayek MikeAlhayek modified the milestones: 1.x, 1.8 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

Fix TheAdmin & TheTheme for RTL languages OrchardCMS/OrchardCore
3 participants
@Skrypt @hishamco @MikeAlhayek