Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong layout for TheBlogTheme Search/NotFound pages #14492

Closed
tbolon opened this issue Oct 12, 2023 · 0 comments · Fixed by #14493
Closed

Wrong layout for TheBlogTheme Search/NotFound pages #14492

tbolon opened this issue Oct 12, 2023 · 0 comments · Fixed by #14493
Labels
Milestone

Comments

@tbolon
Copy link
Contributor

tbolon commented Oct 12, 2023

Describe the bug

When using TheBlog theme, the /Search and /Not-Found theme pages are using a wrong header definition.

The html div header container class attribute is missing "position-relative" class, which results in grayed title due to CSS and overlay and some other layout problems.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new CMS app
  2. Browse to /Search or any non-existing page
  3. The color of the title of the page is gray instead of white

Expected behavior

The page title color should be white instead of gray, the test should be centered.

The culprits seems to be the liquid shared views which are not using the same HTML as the Content.liquid template.

Screenshots

image image image
@tbolon tbolon changed the title Wrong layout for TheBlog Search/NotFound pages Wrong layout for TheBlogTheme Search/NotFound pages Oct 12, 2023
@MikeAlhayek MikeAlhayek added this to the 1.x milestone Nov 3, 2023
@MikeAlhayek MikeAlhayek modified the milestones: 1.x, 1.8 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants