Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shortcode for cache busting #14498

Closed
DemeSzabolcs opened this issue Oct 12, 2023 · 2 comments · Fixed by #14621
Closed

Add a shortcode for cache busting #14498

DemeSzabolcs opened this issue Oct 12, 2023 · 2 comments · Fixed by #14621
Milestone

Comments

@DemeSzabolcs
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Here are the current image shortcodes: https://docs.orchardcore.net/en/latest/docs/reference/modules/Shortcodes/#available-shortcodes

There is no option to add a shortcode for cache busting. For reference, you can add cache busting in a cshtml file like this: @Orchard.AssetUrl(assetPath: path, appendVersion: true).

So if somebody uses an image in (for example) an HTML Body part, there is no way to add cache busting with a shortcode.

Describe the solution you'd like

Adding a shortcode that allows cache busting.

Describe alternatives you've considered

...

@sebastienros sebastienros added this to the 1.x milestone Oct 19, 2023
@sebastienros
Copy link
Member

@DemeSzabolcs please submit a PR for this

@DemeSzabolcs
Copy link
Contributor Author

Sorry for the late response. I will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants