Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding Error Pages from the Template feature #14548

Closed
MikeAlhayek opened this issue Oct 20, 2023 Discussed in #14543 · 8 comments · Fixed by #14545
Closed

Overriding Error Pages from the Template feature #14548

MikeAlhayek opened this issue Oct 20, 2023 Discussed in #14543 · 8 comments · Fixed by #14545
Milestone

Comments

@MikeAlhayek
Copy link
Member

MikeAlhayek commented Oct 20, 2023

Is your feature request related to a problem? Please describe.

I want to be able to override the error pages using the Template feature.

Describe the solution you'd like

Compose the error views as shapes instead of a standard MVC-action view.

Discussed in #14543

@MikeAlhayek MikeAlhayek changed the title How to override a standard action view (MVC action) from the UI Overriding Error Pages from the Template feature Oct 21, 2023
@hishamco
Copy link
Member

Compose the error views as shapes instead of a standard MVC-action view.

What's wrong with overriding the views from the theme or web app?

@MikeAlhayek
Copy link
Member Author

@hishamco
Using a theme is a great default choice. But, what would you do if a tenant want to modify the default message? This is the power of shapes and the beauty of the Templates feature.

@hishamco
Copy link
Member

We might need extra docs or guides on shapes because it's something special to OC, not ASP.NET Core dev. While I'm not using shapes to much I need a way to override views like normal ASP.NET Core application

@MikeAlhayek
Copy link
Member Author

We might need extra docs or guides on shapes because it's something special to OC, not ASP.NET Core dev. While I'm not using shapes to much I need a way to override views like normal ASP.NET Core application

Maybe all you need is to actually use Shapes and OC in a project, so you can learn all about them :)

@hishamco
Copy link
Member

I used them when I create AdminCulturePicker but you destroy everything dude :)

@MikeAlhayek
Copy link
Member Author

I used them when I create AdminCulturePicker but you destroy everything dude :).

Actually I just improved them even more by simplifying their injection process. What you did was good. Anyhow, if it is still a confusing topic for you, maybe use them more often so you can get comfortable. Either way, these comments are off the topic of this PR. Ping me separately if you have questions/comments around Shapes.

@hishamco
Copy link
Member

I'm just kidding

Ping me separately if you have questions/comments around Shapes.

Thanks

@sebastienros
Copy link
Member

Only because the PR adds nice features, not because it's easier to customize

@sebastienros sebastienros added this to the 1.x milestone Oct 26, 2023
@MikeAlhayek MikeAlhayek modified the milestones: 1.x, 1.8 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants