Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize the RequestLocalizationMiddleware asynchronously #14798

Closed
MikeAlhayek opened this issue Nov 30, 2023 · 1 comment
Closed

Initialize the RequestLocalizationMiddleware asynchronously #14798

MikeAlhayek opened this issue Nov 30, 2023 · 1 comment
Labels
bug 🐛
Milestone
1.8

Comments

@MikeAlhayek
Copy link
Member

The options used to add the RequestLocalizationMiddleware to the pipeline make a synchronous call. Not a good idea to block the thread on every request that use localization.
@MikeAlhayek MikeAlhayek mentioned this issue Nov 30, 2023
Closed
@hishamco
Copy link
Member

Please read our comments in the related PR

@jtkech jtkech mentioned this issue Dec 1, 2023
Merged
@MikeAlhayek MikeAlhayek added this to the 1.x milestone Dec 4, 2023
@MikeAlhayek MikeAlhayek modified the milestones: 1.x, 1.8 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

Initialize the RequestLocalizationMiddleware asynchronously OrchardCMS/OrchardCore
2 participants
@hishamco @MikeAlhayek