Media field translated script should be improved

[sebastienros]

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Media/Views/MediaField-Attached.Edit.cshtml#L43

The translation should go in a separate tag and be read by the script to inject the name and size.

[DonaldDWebster]

https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.Media/Views/MediaField-Attached.Edit.cshtml#L43

The translation should go in a separate tag and be read by the script to inject the name and size.

Are you referring to a fix like the one below? I'm still getting familiar with the codebase, so I'm trying to better understand your suggestion. Thanks for your help!

<label class="selected-media-name form-label">
    <code class="text-end" v-if="selectedMedia">
	<span v-html="getTranslatedSelectedMediaNameAndSize"></span>
    </code>
</label>

<script at="Foot">
	function getTranslatedSelectedMediaNameAndSize() 
	{
		const fileName = this.selectedMedia.attachedFileName || this.selectedMedia.name;
		const mediaText = this.selectedMedia.mediaText ? `, ${this.selectedMedia.mediaText}` : '';
		const fileSize = isNaN(this.selectedMedia.size) ? 0 : Math.round(this.selectedMedia.size / 1024); //bytes to KB

		return `${fileName}${mediaText} (${fileSize} KB)`;
	}
</script>