contentpreview-edit.js doesn't declare jQuery as its dependency

[Psichorex]

Describe the bug

After upgrading to Orchard Core 1.8 some preview buttons inside of content item editors become broken.
They are broken because the driving script behind it called contentpreview-edit has an exception of:

$ is not defined is almost always due to a script being called before jQuery is registered.
Same happens in Orchard Core as the problematic content items have contentpreview-edit script registered prior to jquery.js
Making a code that brings jquery in front resolved the problem.

contentpreview-edit doesn't declare jquery as it's dependency:
Nor in its corresponding ResourceManagementOptionsConfiguration
https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.ContentPreview/ResourceManagementOptionsConfiguration.cs#L14-L17
Nor in the script inclusion in the Razor.
https://github.com/OrchardCMS/OrchardCore/blob/main/src/OrchardCore.Modules/OrchardCore.ContentPreview/Views/ContentPreview.Button.cshtml#L22

I can't write a direct way of reproducing this because when I am creating a Content Type from the Admin page it works but Content Types that are coming from Migrations and custom code are broken.

Either way contentpreview-edit should have jquery declared as its dependency.

[Piedone]

Please provide repro steps so we can check it being broken and indeed fixed after adding a dependency.

[Psichorex]

@Piedone I can only provide reprosteps for our OSOCE repository.
But it's basically go to ContentItems list and open any custom type:

Also there are pages where it's working:

Where it's not working all those pages have contentpreview-edit registered first and jquery just after.

[Piedone]

Please provide an export of the content type you're using. Something is different than the built-in Blog Post, since if you check that with the latest source, this doesn't happen.

[Piedone]

And first make sure that this also happens with the OC source, i.e. it's not caused by anything in the custom solution.

[MikeAlhayek]

This is probably an issue after upgrading the admin theme. Can you submit a PR to adding to this?
@Psichorex can you submit a PR by adding the line .SetDependencies("jQuery") to this?

OrchardCore/src/OrchardCore.Modules/OrchardCore.ContentPreview/ResourceManagementOptionsConfiguration.cs

Line 17 in f843b91

.SetVersion("1.0.0");

We should spend time to remove jQuery from these older scripts.

[Psichorex]

This is probably an issue after upgrading the admin theme. Can you submit a PR to adding to this? @Psichorex can you submit a PR by adding the line .SetDependencies("jQuery") to this?

OrchardCore/src/OrchardCore.Modules/OrchardCore.ContentPreview/ResourceManagementOptionsConfiguration.cs

Line 17 in f843b91

.SetVersion("1.0.0");

We should spend time to remove jQuery from these older scripts.

@MikeAlhayek Seems like I don't have the permission to commit. I thought I was added as a contributor. TL:DR I can't open a PR.

[Piedone]

You need to work in a fork.

[Psichorex]

I will add this in our fork.

[MikeAlhayek]

yes create a branch out of your fork. then create a cross repository into OC main branch. Feel free to ping me when you create the PR.

[Psichorex]

@MikeAlhayek here is the PR in our Fork
#15183