-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization of Custom Settings ContentType by LocalizationPart #15237
Comments
Maybe the controller for the custom settings needs to be made localization-aware. In the Settings feature, the controller might need to accept a culture argument to edit this specific instance. |
This happens because the content item is saved in |
does it really have something to do with the indexes? The settings is a sub property named by its type. It just needs to have another level of indirection by culture, and fetch it differently. |
I thought about that, but there's a localized set that should be in the index, right? |
Even if we add culture as a level when we try to localize the content the localized link will throw an exception because the controller looks for the content item id This might be need a discussion |
Custom Settings are not managed like other content items. They are not documents that are indexed. We just serialize them as a json property of the unique This service should be extended to provide a localization argument, such that the UI can have a drop down to select which culture we want to edit the settings for, and also to load a specific setting for the current culture. This will probably also require a migration to move existing settings in an array, in case we want each localized content item to be seekable by its LocalizationSet/ILocalizedPart properties. |
I'm aware of the difference here, what I'd like to say is that the localized versions are managed differently, in the case of CustomSettings we might need to manage the cultures either
|
I have an issue similar to this. I have modeled the categories in my website after those in The controller tries to fetch an item not created yet. |
@ashrafsabrym this need a design |
I think there's issue or not supported yet, I remember @urbanit addressed that long time ago |
I've the same problem. |
Describe the bug
Using a Custom Settings ContentType, which contains the localization ContentPart, it is not possible to add a localized version of the settings. Instead you get a "The page could not be found." message with the URL /Admin/ContentLocalization
Previous discussion about the bug
#14908
To Reproduce
Steps to reproduce the behavior
Expected behavior
The settings page should be shown with a localized version of the settings to be edited an saved.
Screenshots
The text was updated successfully, but these errors were encountered: