Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] DataMigrationExtensions - Create vs CreateAsync #15394

Closed
MikeKry opened this issue Feb 24, 2024 · 1 comment · Fixed by #15396
Closed

[suggestion] DataMigrationExtensions - Create vs CreateAsync #15394

MikeKry opened this issue Feb 24, 2024 · 1 comment · Fixed by #15396
Milestone

Comments

@MikeKry
Copy link
Contributor

MikeKry commented Feb 24, 2024

I ran into a problem with datamigrations recently. My migrations did not proceed after initialization of module. After a while, I have noticed it is caused by change of synchronous code to asynchronous and only problem was that I forgot "Async" suffix in "CreateAsync" method.

That is OK I guess, but there is incosistency in behavior of UpdateFromX(Async) and Create(Async). Updates work correctly no matter of suffix, but Create does no. I think it would be good to unify this behavior - either force Async suffix even on Update methods or (which i prefer) allow Create method without Async suffix.

@MikeAlhayek MikeAlhayek added this to the 1.x milestone Feb 24, 2024
@MikeAlhayek
Copy link
Member

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants