Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About “Owner” and "Author" property #15458

Open
hyzx86 opened this issue Mar 5, 2024 · 4 comments
Open

About “Owner” and "Author" property #15458

hyzx86 opened this issue Mar 5, 2024 · 4 comments
Milestone

Comments

@hyzx86
Copy link
Contributor

hyzx86 commented Mar 5, 2024

  1. Many places have an assignment procedure for this field, can we use a location unified processing?
    image

  2. Looking at the Author's assignment process, it seems that it is allowed to be empty, But this field is not set to allow null in the ContentItemInterface , (PR :Author field perhaps is null #15457)

  3. The Author and Owner store different values, one is the userName and the other is the User ID, which seems to have no special significance, do we need to refactor? Make it unified?

  4. We already have support for me field in the Graphql api, and I've also submitted functionality for UserPickerField (PR: Add GraphQL support to UserPickerField #15389) It is better to be able to provide direct support directly on the Owner and Author fields, as UserPickerField does

  5. So, for now it seems necessary to create a UserInterface for the user type just like the ContentItemInterface

@hyzx86
Copy link
Contributor Author

hyzx86 commented Mar 5, 2024

Hi @gvkries , Perhaps you have some thoughts on these suggestions?

@MikeAlhayek
Copy link
Member

The Author and Owner store different values, one is the userName and the other is the User ID, which seems to have no special significance, do we need to refactor? Make it unified?

The idea behind the Author is so you can render it without having to fetch user info every time on the content item listing.

@sebastienros
Copy link
Member

Owner needs the id since it's used for technical reasons (permissions mostly).

@sebastienros sebastienros added this to the backlog milestone Mar 7, 2024
@hyzx86
Copy link
Contributor Author

hyzx86 commented Mar 11, 2024

Owner needs the id since it's used for technical reasons (permissions mostly).

My idea was to extend ContentItemInterface to allow to query the item's Autor and Owner directly in Graphql for CustomUserSettings like displayName
Should we add a field like AuditInfo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants