Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LinkGenerator instead of UrlHelper to generate URL #15658

Open
MikeAlhayek opened this issue Apr 4, 2024 · 3 comments
Open

Use LinkGenerator instead of UrlHelper to generate URL #15658

MikeAlhayek opened this issue Apr 4, 2024 · 3 comments
Milestone

Comments

@MikeAlhayek
Copy link
Member

When we need to generate URL, we typically inject IUrlHelperFactory and IActionContextAccessor to create an instance if IUrlHelper for creating a URL.

When the request comes in from Minimal API or background task, there is no action context available which will throw exceptions. It's better to inject LinkGenerator instead and use the methods to generate Url or Paths as needed.

@Piedone
Copy link
Member

Piedone commented Jun 7, 2024

This should only be done after we fix #16259.

@Piedone
Copy link
Member

Piedone commented Jun 7, 2024

Where does this come up, exactly? Where have you seen link generation failing during a minimal API call or a bg task? Since I suppose it's not that we'd want to change all the IUrlHelperFactory usages.

@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Jun 7, 2024

I don't recall the details. But if you trigger workflow for example from a minimalAPI and you have workflow that use IUrlHelperFactory it would throw an exception. LinkGenerator is the correct way to generate links. We just have to use extensions that accept HttpContext instance as an argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants