Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use DefaultAzureCredential for Azure BlobFileStore #15663

Closed
mariojsnunes opened this issue Apr 5, 2024 · 6 comments
Closed

Add option to use DefaultAzureCredential for Azure BlobFileStore #15663

mariojsnunes opened this issue Apr 5, 2024 · 6 comments

Comments

@mariojsnunes
Copy link
Contributor

mariojsnunes commented Apr 5, 2024

Is your feature request related to a problem? Please describe.

Using a Managed Identity (DefaultAzureCredential) is safer than using connection strings. Also allows to use RBAC to control access.

Describe the solution you'd like

A simple solution would be to add a boolean flag UseDefaultAzureCredential to BlobStorageOptions and instantiate the BlobFileStore according to it.
Or could have a more flexible solution similar to Azure KeyVault .AddOrchardCoreAzureKeyVault(new DefaultAzureCredential())

@Piedone
Copy link
Member

Piedone commented Apr 7, 2024

Is this something you'd venture into contributing if I help with pointers?

@mariojsnunes
Copy link
Contributor Author

Yes I'd be happy to

@Piedone
Copy link
Member

Piedone commented Apr 8, 2024

Great! Some suggestions:

@rjpowers10
Copy link
Contributor

Maybe related? #12874

@mariojsnunes
Copy link
Contributor Author

yep it is

@Piedone
Copy link
Member

Piedone commented Apr 8, 2024

Indeed, this is a duplicate of #12639.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants