-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On workflow module optimisation #16107
Comments
@hyzx86 also a description field for the workflow type definition would be usefull (along with display name). |
Yes, I agree, it could be used to keep some change logs or business notes or something like that. |
Basically from list of workflows to see and remember what it does and the outcomes so you dont have to look into the designer to recall what its doing. |
That would be DisplayName. 😁 |
the display name would : handles submissions from form http://mysite.com. Sends emails to moderator and integrates with crm bla bla.... Display name is something short and description expands more. |
@hyzx86 personally i would not change anything else apart from replacing js plumb with x6 . changing the activity UI forms to depend on a javascript library is not something i would prefer. |
This is not that simple. First of all, our current workflow node editing is based on form submissions, and we want to refactor it to SPA, so we first need to change the way each node is saved from a per-submission to the server to a client-side staging. |
......., and we want to refactor it to SPA, ..... why have you come to a conclusion that we need to refactor it to a SPA ? |
This is a change based on workflow versioning, as currently every time a workflow node is saved the entire workflow type is directly submitted and saved to the database |
and why is that a problem ? just save the entire workflow json and do a diff evalutaion of the changes . content item versioning works the same. |
Whenever we click on the Save button of a workflow node, a new version of the workflow type is generated, if when you need to create a workflow definition with 20 nodes, then at least 20 versions will be generated |
I don't think we have anything formalized, but I'd say they need to have a license compatible with OC's, actively developed, have a sufficiently high quality, and with everything available in English (as well). |
We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues). This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here. |
Is your feature request related to a problem? Please describe.
To date, we have collected a number of questions and suggestions for the workflow module
Below I've summarised and collated these encounters, and we've tried to consolidate them into one PR as much as possible, as separating them into different PRs may require multiple changes to the multi-table structure, and may also require the introduction of many destructive updates
Workflow support for versioning, including audit information
Other enhancements
Workflow Type
TitlePart
doesDescription
field to a workflow type,can save text that describes the process.DisplayName
field for a short description to distinguish it from the technical name.Workflow Instance
ExecutedOnUtc
field to workflow instances, which can be used for sortingCreatedUtc
,ModifiedUtc
,ModifiedBy
,CreatedBy
If there are any other suggestions, please add them.
Describe the solution you'd like
I am currently trying to implement these changes in PR #16043
The text was updated successfully, but these errors were encountered: