Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to enable 2FA using email when the email is not verified #16129

Closed
MikeAlhayek opened this issue May 21, 2024 · 4 comments · Fixed by #16130
Closed

Unable to enable 2FA using email when the email is not verified #16129

MikeAlhayek opened this issue May 21, 2024 · 4 comments · Fixed by #16130
Labels
Milestone

Comments

@MikeAlhayek
Copy link
Member

Describe the bug

To Reproduce

Steps to reproduce the behavior:

  1. add user
  2. make sure the user email is not verified
  3. let the user try to enable 2FA using email method.
  4. This generated a very long token that isn't numeric. So it's can't be used for verification.

Expected behavior

The token should be a 6 digit numeric valid

Screenshots

If applicable, add screenshots to help explain your problem.

@hishamco
Copy link
Member

How the 2FA code will be send if the email is not configured?

@MikeAlhayek
Copy link
Member Author

The email will be already configured. The issue isn’t sending the message. The issue is with the generated token. The referenced PR fixed the issue.

@Piedone
Copy link
Member

Piedone commented May 22, 2024

I'd rather display a message that you should verify your email first, and prevent enabling 2FA until then. Otherwise, we can't make sure the email will actually arrive.

@MikeAlhayek
Copy link
Member Author

I'd rather display a message that you should verify your email first, and prevent enabling 2FA until then. Otherwise, we can't make sure the email will actually arrive.

I did exactly that in the referenced PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants