ControllerTypeExtensions ControllerName should look for ControllerBase

[Skrypt]

ControllerTypeExtensions ControllerName should look for ControllerBase type instead of Controller.

OrchardCore/src/OrchardCore/OrchardCore.Mvc.Core/Utilities/ControllerTypeExtensions.cs

Lines 10 to 13 in a95a876

	if (!typeof(Controller).IsAssignableFrom(controllerType))
	{
	throw new ArgumentException($"The specified type must inherit from '{nameof(Controller)}'", nameof(controllerType));
	}

ApiController should also inherit from ControllerBase instead of Controller.

[sebastienros]

https://stackoverflow.com/questions/55239380/why-derive-from-controllerbase-vs-controller-for-asp-net-core-web-api

[Skrypt]

Yes, ControllerBase here should support both.

[Skrypt]

@sebastienros Unless what you meant is that I should revert the change so that we can keep the ControllerBase as clean as possible? It just feels wrong to me to need to inherit from Controller on an ApiController. And I was not really into creating another inheritance on top of ControllerBase just for this.