Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize options editor #16256

Open
xnavrat4 opened this issue Jun 6, 2024 · 4 comments
Open

Generalize options editor #16256

xnavrat4 opened this issue Jun 6, 2024 · 4 comments
Milestone

Comments

@xnavrat4
Copy link

xnavrat4 commented Jun 6, 2024

Is your feature request related to a problem? Please describe.

I wanted to reuse options editor for a custom TextField editor. While doing this, I noticed that while the optionsEditor.js's initializeOptionsEditor function offers a lot of parameters, the template id is hardcoded to #options-table. This makes it difficult to use fot other textfield editors.

Describe the solution you'd like

add id parameter to the initializeOptionsEditor funcion.

Does it seem reasonable?
Thanks for considering it.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Thank you for submitting your first issue, awesome! 🚀 We're thrilled to receive your input. If you haven't completed the template yet, please take a moment to do so. This ensures that we fully understand your feature request or bug report. A core team member will review your issue and get back to you.

If you like Orchard Core, please star our repo and join our community channels.

@Piedone
Copy link
Member

Piedone commented Jun 6, 2024

This doesn't seem like a big deal to implement, but I'm curious, what kind of custom editor do you have, exactly? Since that script is specific to localization options.

@sebastienros
Copy link
Member

@sebastienros sebastienros added this to the 2.x milestone Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants