Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task-type Workflows Activities an also be set as startup task #16345

Closed
Piedone opened this issue Jun 19, 2024 · 3 comments · Fixed by #16351
Closed

Task-type Workflows Activities an also be set as startup task #16345

Piedone opened this issue Jun 19, 2024 · 3 comments · Fixed by #16351

Comments

@Piedone
Copy link
Member

Piedone commented Jun 19, 2024

Describe the bug

You can set Task-type Activities as startup tasks on the workflow canvas. However, this doesn't make sense, since a Task can't start a workflow, only an Event can.

Orchard Core version

22fbbb4

To Reproduce

  1. Add any Task like Notify to a workflow.
  2. Notice that you can set it as a startup task.

Expected behavior

The startup task button only appears for events. Also, the terminology "startup task" is incorrect as well, since it should say "startup event".

Logs and screenshots

E.g. a Notify Task can't start a workflow, but you can set it as a startup task:

image

@MikeAlhayek
Copy link
Member

@Piedone I think this issue should remain open. I agree that the first thing that should be added to a workflow is an event. This is something Elsa workflow does well. However, the highlighted power button in your screenshot is to enable/disable task or event. We can't remove the power button unless we was to abandon the idea to enable/disable a task.

removing the power button will prevent us from enabling any task. Please see issue #16512

@MikeAlhayek MikeAlhayek reopened this Aug 1, 2024
@Piedone
Copy link
Member Author

Piedone commented Aug 1, 2024

Why do we need this issue open if there's #16512.

@MikeAlhayek
Copy link
Member

If I understand this issue correctly, the ask is to not be able to add task if there is no action. The very first thing on the top should be an event not a task. So this is a valid request and should be done (hopefully by using Elsa editor instead).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants