Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell blueprint is missing dependencies #16375

Closed
gvkries opened this issue Jun 26, 2024 · 3 comments · Fixed by #16379
Closed

Shell blueprint is missing dependencies #16375

gvkries opened this issue Jun 26, 2024 · 3 comments · Fixed by #16379
Labels
Milestone

Comments

@gvkries
Copy link
Contributor

gvkries commented Jun 26, 2024

Describe the bug

During startup, the ShellContainerFactory is relying on the ShellBlueprint.Dependencies property to get all startup classes that needs to be added to DI. But if an extension contains only features that do not match the extension ID, dependencies without any feature assignment are not added to the blueprint at all.

That means that some startup classes not executed at all.

Orchard Core version

Reproducible in 1.8.3 and later. I didn't check earlier versions.

To Reproduce

  1. Enable the features Microsoft Entra ID Authentication and Deployment.
  2. Create a deployment plan and add steps to it. The Microsoft Entra ID step is missing there, because its startup class OrchardCore.Microsoft.Authentication.DeploymentStartup is not executed.

Expected behavior

All startup classes which meet their dependencies should be executed.

Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@Piedone
Copy link
Member

Piedone commented Jul 2, 2024

Did you notice any other features affected in the current source?

@gvkries
Copy link
Contributor Author

gvkries commented Jul 2, 2024

This is a general issue, but I didn't search for other cases explicitly.

@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants