-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The non-debug versions of certain static resources aren't loaded when Resource Debug Mode is set to Enabled #16401
Comments
This doesn't seem to be related to the resource having dependencies or not, being defined in a template or a config file, or |
From these, only _manifest
.DefineScript("admin")
.SetDependencies("bootstrap", "admin-main", "theme-manager", "jQuery")
.SetUrl("~/TheAdmin/js/TheAdmin.min.js", "~/TheAdmin/js/TheAdmin.js")
.SetVersion("1.0.0");
_manifest
.DefineScript("admin-main")
.SetUrl("~/TheAdmin/js/TheAdmin-main.min.js", "~/TheAdmin/js/TheAdmin-main.js")
.SetDependencies("theme-head", "js-cookie")
.SetVersion("1.0.0");
_manifest
.DefineStyle("admin")
.SetUrl("~/TheAdmin/css/TheAdmin.min.css", "~/TheAdmin/css/TheAdmin.css")
.SetVersion("1.0.0"); If I remove its dependencies and that of |
This is enough to reproduce the problem in _manifest
.DefineScript("admin")
.SetDependencies("admin-main")
.SetUrl("~/TheAdmin/js/TheAdmin.min.js", "~/TheAdmin/js/TheAdmin.js")
.SetVersion("1.0.0");
_manifest
.DefineScript("admin-main")
.SetUrl("~/TheAdmin/js/TheAdmin-main.min.js", "~/TheAdmin/js/TheAdmin-main.js")
.SetVersion("1.0.0");
_manifest
.DefineStyle("admin")
.SetUrl("~/TheAdmin/css/TheAdmin.min.css", "~/TheAdmin/css/TheAdmin.css")
.SetVersion("1.0.0");
|
Describe the bug
Orchard Core version
4aeaaf9
To Reproduce
/TheAdmin/css/admin-layout.min.css
,/OrchardCore.Resources/Scripts/jquery.min.js
, and/OrchardCore.Resources/Scripts/trumbowyg/trumbowyg.min.js
, despite all of these having non-minified debug versions configured. Not all resources are affected though, e.g./OrchardCore.Html/Scripts/trumbowyg.media.tag.js
and/OrchardCore.Resources/Scripts/trumbowyg/trumbowyg.shortcodes.js
are correctly loaded as the debug versions.Expected behavior
With Resource Debug Mode set to Enabled only the non-minified resources are loaded.
Logs and screenshots
Foot scripts with Resource Debug Mode enabled:
And disabled:
Head scripts and stylesheets enabled:
Disabled:
Notice how the affected foot scripts seem to all lack the cache-busting
v
query string parameter as well when Resource Debug Mode is set to Enabled, which is another, most possibly related issue. This is not so clearly the case for the head resources though.The text was updated successfully, but these errors were encountered: