Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve setup UX when using a password manager #16465

Closed
sarahelsaig opened this issue Jul 20, 2024 · 4 comments · Fixed by #16466
Closed

Improve setup UX when using a password manager #16465

sarahelsaig opened this issue Jul 20, 2024 · 4 comments · Fixed by #16466

Comments

@sarahelsaig
Copy link
Contributor

Is your feature request related to a problem? Please describe.

During local development you will want to reuse saved admin credentials. Using the browser's password manager is helpful here, but the setup screen fails to anticipate this scenario. As you fill in the saved password, the strength bar under the password field doesn't update and the "Finish Setup" button won't do anything, as if broken. You have to click into the password field and press a key. This is a minor annoyance, but it's persistent and irritating when you work with OC a lot.

setup-doesnt-respect-stored-passwords.webm

Describe the solution you'd like

The strength function should handle change events too, not just keydown and keyup. Also clicking on the "Finish Setup" button should trigger it as well, instead of silently failing.

@Piedone
Copy link
Member

Piedone commented Jul 22, 2024

While this is indeed annoying, if you do a lot of OC setups, rather you should automate it. I thought about this for reviews of OC PRs, and I'm not yet satisfied with either:

  • Configure Auto Setup for myself but don't commit it (like appsettings changes) to run the setup on on the first request.
  • Add Setup Extensions and script the setup but don't commit it.
  • I haven't tried but script the setup with Selenium or something (this won't be part of the repo anyway).

@sarahelsaig
Copy link
Contributor Author

While this is indeed annoying, if you do a lot of OC setups, rather you should automate it.

both

  • Configure Auto Setup for myself but don't commit it (like appsettings changes) to run the setup on on the first request.

Editing a file tracked by git is an instant deal breaker for me, because that's even more annoying than the problem I described above. But now I wonder, is it possible to seamlessly enable and configure autosetup from command line switches or environment variables instead of the appsettings.json file?

@Piedone
Copy link
Member

Piedone commented Jul 22, 2024

Hmm, actually yed, since Auto Setup is added in the Program file, it should be configurable from env vars too.

@sarahelsaig
Copy link
Contributor Author

I think user secrets are the way to go for configuring AutoSetup. They are straight forward to set up and use, can't be committed into git, don't seep into other projects. You only have to add a single line of <UserSecretsId>{random GUID}</UserSecretsId> to the startup project's csproj which is safe and not intrusive. I've updated the AutoSetup docs in the PR to mention this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants