Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default content parts sort order should be base on the insertion position #16515

Open
MikeAlhayek opened this issue Aug 2, 2024 · 2 comments
Labels
Milestone

Comments

@MikeAlhayek
Copy link
Member

Describe the bug

I create a new content type (Member) by attaching TitlePart only. Then Added Biography field. Note here I did not change the order of the parts yes using the drag/drop. So every thing is left as is. As you can see from the following screenshot, I would expect that the fields to be rendered below the title part since Title part shows us on the top of the parts list.

image

However, when I try to create a member, Title part renders after the biography.

image

Now, if I edit the member content type and drag the title part below "Member" and move it back to it's original spot then save, everything shows up as expected.

image

Orchard Core version

This issue is in main branch but I think goes back to previous versions.

Expected behavior

By default, the fields should be rendered in the position of the MemeberPart that is added by default. Parts should also be rendered in the order they appear in the content type editor "unless someone overrides this using display driver or placement"/

@sebastienros
Copy link
Member

The parts position in the content type definition might not be set correctly when a part is added. We need to compare the json before and after the parts are re-ordered.

@sebastienros sebastienros added this to the 2.x milestone Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants