Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Failed event fires twice if you attempt to sign in using invalid password for an existing user #16551

Closed
mvarblow opened this issue Aug 13, 2024 · 1 comment · Fixed by #16552

Comments

@mvarblow
Copy link
Contributor

Describe the bug

If you enable the user audit trail events and then attempt to sign in but type the wrong password you'll notice that three events are recorded:

  1. A user updated event (the AccessFailedCount was incremented)
  2. A login failed event that includes the user ID
  3. A duplicate login failed event that does not include the user ID

Within the AccountController.Login method you can see that the LoggingInFailedAsync handler fires twice if the user is found (or just once if the user was not found).

Orchard Core version

1.8.3

To Reproduce

See above.

Expected behavior

The LoggingInFailedAsync handler should fire once and the audit trail event should be recorded once (with the user ID included).

Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants