Move OrchardCore.Translations.All

[Skrypt]

To OrchardCore.Application.Cms.Core.Targets

Fixes #17035

[Piedone]

This looks like a good change to me but @hishamco please comment.

[sebastienros]

Should we split Translation.All in two such that Core can reference core module translations, and .All include Cms modules too?

[Skrypt]

@sebastienros That would be even better.

Translation.Core.All
Translation.CMS.All

Though, the thing is that currently the OrchardCore.Application.Cms.Targets is only there for including OC themes to the OrchardCore.Cms.Web project.

We would need to split translations for CMS modules vs Core Modules. Then have 3 or 4 .targets projects to included them all separately. I'm not sure if we have everything splitted up with Core and Modules. That may cause some issues of missing translations in the beginning.

Here, I remember that we set the Translations.All in the Cms.Target because we wanted to make the main one to be lightweight but that doesn't make sense to have modules that can be translated without having translations. We end up adding the reference to our web project. And it doesn't follow the same version as the current one which can lead to forgetting upgrading it along with the OC version.

[hishamco]

I think the main issue here is that we include all the translations even if we didn't use them, what if we include them on demand?

I saw some CMS load the translations on the fly, but while we don't have this capability we could install them using dotnet CLI

[sebastienros]

@Skrypt I could check ... but as I understand it the "All" is for "all languages", not "all modules" ? If so then the change is fine.

[Skrypt]

@sebastienros It is both all languages and all modules. We don't make a distinction yet between Core and Modules. I think that's maybe the enhancement we could have. This way we could just use Core translations when we want to use OC as a framework so that we can get the DataAnnotation translations as an example.

But in the mean time I think this PR is adequate because you at least want all translations if you don't have a choice.

At the same time here we are talking about a Nuget package that is 8.3 MB so it is maybe neglectable for most people?