Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Time Zone feature results in DI loop #17069

Open
mvarblow opened this issue Nov 26, 2024 · 1 comment
Open

User Time Zone feature results in DI loop #17069

mvarblow opened this issue Nov 26, 2024 · 1 comment
Labels

Comments

@mvarblow
Copy link
Contributor

mvarblow commented Nov 26, 2024

Describe the bug

After enabling the User Time Zone feature, the site hangs and no longer responds to new requests.

Orchard Core version

2.1, 2.1.1

To Reproduce

  1. Clone the repo
  2. Start the OrchardCore.Cms.Web project
  3. Use the default recipe and complete setup
  4. Login and go to the Features admin page
  5. Enable the User Time Zone feature
  6. The site hangs

Expected behavior

The site should continue to function, but with the user time zone feature enabled.

Logs and screenshots

After the site hangs, I can break in the debugger and inspect the call stack. It's truncated by VS to about 4000 call sites. This is repeated on the call stack over and over:

image

That repeated section of call stack includes this:

image

and this:

image

@mvarblow
Copy link
Contributor Author

@MikeAlhayek, I think this PR introduced the problem.

#16942

Reverting that PR seems to resolve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant