Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the admin site #3473

Closed
hishamco opened this issue Apr 16, 2019 · 14 comments
Closed

Polish the admin site #3473

hishamco opened this issue Apr 16, 2019 · 14 comments
Milestone

Comments

@hishamco
Copy link
Member

This include:

  • Give login a better look and feel
  • Display OrchardCore features in admin dashboard
  • Colorize the admin menu bar

Login

Dashboard-CollapsedMenu

Dashboard-ExpandedMenu

Your thoughts @sebastienros @jtkech @Skrypt @Jetski5822 @agriffard

@agriffard
Copy link
Member

As far as I am concerned, I don't like this background color since O1.

The login form is designed to be minimal on purpose and can be overriden from the theme if needed.

For the dashboard, an issue is open to allow to manage the items that appear on the admin homepage: #2246
I agree that we need more information on that screen but I don't think it has to be some technical content.

@Skrypt
Copy link
Contributor

Skrypt commented Apr 16, 2019

I like what you did with the login page. Though the green color makes it look military which I'm not a fan of. For the dashboard, I myself too made changes in that dashboard and my changes got refused and the reason is quite simple, the dashboard should be customizable. So, right now the dashboard is kept simple until someone works on it. The only thing I would consider merging is the login customization since it can be overridden.

@hishamco
Copy link
Member Author

As far as I am concerned, I don't like this background color since O1.

Though the green color makes it look military which I'm not a fan of.

The military color 😄 as @Skrypt mentioned earlier is the current color for Orchard logo, we can changes it when the logo change or Orchard CMS re branded

Regarding the dashboard I will clean it up until we enhance it to support droplets aka widgets. For that I will make a PR for the login page and changing the admin menu bar if everyone happy with the changes

@sebastienros
Copy link
Member

How does it look like when the "front end" login feature is enabled?
I like it how it is right now, we should probably work on making it extensible instead.

@Skrypt
Copy link
Contributor

Skrypt commented Apr 16, 2019

I believe that there are also alternate logo's of Orchard that are in shades of grey and that's not a reason to use that everywhere. The general idea for the admin design is AFAIK to mimic Azure DevOps aka VSTS new design. I'd say that what you did is a great alternate design for the admin but I wouldn't use it for myself or for a corporate use where you want to keep the design as un-opiniated as possible or as common as possible. That green color just makes it look military...

@hishamco
Copy link
Member Author

How does it look like when the "front end" login feature is enabled?

I didn't try it, but we should have different style for each one, because the front-end login controlled by site them

I'd say that what you did is a great alternate design for the admin but I wouldn't use it for myself or for a corporate use where you want to keep the design as un-opiniated as possible or as common as possible. That green color just makes it look military...

Everyone has it's own opinion, so choose the theme you like 😄

@Skrypt
Copy link
Contributor

Skrypt commented Apr 17, 2019

Everyone has it's own opinion, so choose the theme you like

That's not much about my taste but more about the fact that we started using VSTS as a design guideline. What you are trying to do with your PR is to make us use it as the default theme. A contrib theme would be more appropriate. Your PR doesn't let me choose.

@hishamco
Copy link
Member Author

Is there any Orchard Core.Contrib repo for stuff that's driven by the community and not committed in the original repo?

@Skrypt
Copy link
Contributor

Skrypt commented Apr 17, 2019

We don't have any theme and/or module gallery but the first step would be to create a repo with your contrib theme under your own Github account simply. I think we will have people create a list of contrib modules untill we get a proper gallery.

@hishamco
Copy link
Member Author

But we need a place at least to refer these repos, so everyone can know the available modules, themes, language packages .. etc

@Skrypt
Copy link
Contributor

Skrypt commented Apr 17, 2019

Something like this could be done easily for now :
https://github.com/thangchung/awesome-dotnet-core
That's what has been proposed so far. A proper gallery could work too if someone wants to start contributing on it. I'm pretty sure that's in the plans. The priority right now is to ship OC first.

@Skrypt
Copy link
Contributor

Skrypt commented Apr 17, 2019

Also, I've not tried it, but once @jtkech will be mostly done with his PR on migrating to .NET Core 3.0 we will be able to start looking back at prototypes for loading/unloading modules on runtime. Which will make more sense if we want a Gallery. That's pretty much why we don't have any yet. Right now you need to recompile your solution if you want to add anything to your project.

@sebastienros
Copy link
Member

looking back at prototypes for loading/unloading modules on runtime

no we won't

@sebastienros sebastienros added this to the backlog milestone Apr 18, 2019
@Skrypt
Copy link
Contributor

Skrypt commented Apr 19, 2019

That closes the off topic 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants