Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve add widget UI on Flows #3558

Open
peterkeating opened this issue May 1, 2019 · 5 comments
Open

Improve add widget UI on Flows #3558

peterkeating opened this issue May 1, 2019 · 5 comments

Comments

@peterkeating
Copy link
Contributor

The current implementation of adding widgets within a flow doesn't extend well when there are a large amount of widgets, as shown below.

flows-existing-add-widget

An alternative is to replace the dropdown button with a modal popup that'll open the door to other possibilities like filtering, ordering, grouping (grouping may need some more thought behind it), etc...

I've had a quick play with the current implementation and threw together a short screen recording to give a better idea of the direction I was thinking.

flows-demo-add-widget

Be great to get any thoughts/further suggestions and confirmation to whether it's worth implementing something more concrete and submit a PR.

@sebastienros
Copy link
Member

Next, grouping and custom shapes which would allow us to use custom rendering (icons or images for instance). Search box also maybe?

@sebastienros
Copy link
Member

The group could be a type setting, which could later be integrated in the content type editors if we want to change it.

@peterkeating
Copy link
Contributor Author

peterkeating commented May 2, 2019

@sebastienros Awesome, I'll crack on then!

Could you explain how you see custom shapes working? Do you mean a shape for customising the display of card that represents the widget in the modal?

Using a setting in the content type for the grouping was what I was thinking too 👍

@sebastienros
Copy link
Member

Yes for the shapes. The idea is that you render a widget with a specific display type, like Thumbnail (look at how it's done for Workflows, or Recipe Steps, ...) and then there is a default template named Widget.Thumbnail.cshtml, but because you add a custom alternate like Widget_Thumnbail-[WithType] any module could then provide a custom template for each widget. But at the same time it can be done later, AND it might not be that useful as most widgets will be dynamic.

@sebastienros sebastienros added this to the 1.1 milestone May 2, 2019
@peterkeating
Copy link
Contributor Author

More often than not we’re creating widgets via recipes, so perhaps the thumbnail could be specified in the content type settings similar to the group?

Still think having the shape would be useful too for consistency and to give the option to override it with an alternate like you’ve mentioned. This would also be useful if you want to override the shape in a custom admin theme too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants