Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ElasticSearch module #4316

Closed
sebastienros opened this issue Sep 17, 2019 · 18 comments · Fixed by #11052
Closed

Implement ElasticSearch module #4316

sebastienros opened this issue Sep 17, 2019 · 18 comments · Fixed by #11052
Milestone

Comments

@sebastienros
Copy link
Member

Same as Lucene

@sebastienros sebastienros added this to the 1.0.x milestone Sep 17, 2019
@hishamco
Copy link
Member

You read my mind, yesterday I was read a great post on ElasticSearch

@Skrypt Skrypt changed the title Implement ElastciSearch module Implement ElasticSearch module Sep 17, 2019
@hishamco
Copy link
Member

FYI this is a good article https://khalidabuhakmeh.com/search-experiences-for-your-aspnet-core-apps-with-elasticsearch

@Mpdreamz
Copy link

Hi! I work for Elastic feel to to @ me on PR's happy to help/answer questions.

@hishamco
Copy link
Member

@Mpdreamz if you are interested you could start in the PR for this module

@Skrypt
Copy link
Contributor

Skrypt commented Sep 30, 2019

The ElasticSearch module should leverage Nest for Queries. We have now Lucene Queries which uses the Lucene Query API but ElasticSearc has already this done with Nest. So we should end up with ElasticSearch Queries that should be quite the same than Lucene Queries with some small differences here and there since Nest for example can use Exists Queries.

@Skrypt
Copy link
Contributor

Skrypt commented Sep 30, 2019

I think we need to first make a service to retrieve different Indexing Providers. And I think we should be able to still use Lucene and/or ElasticSearch at the same time.

@jtkech
Copy link
Member

jtkech commented Oct 1, 2019

@Mpdreamz thanks for proposing to help us!

@cjkihl
Copy link

cjkihl commented Apr 3, 2020

+1 for this feature. 👏

@mickdelaney
Copy link

Is there an interface(s) I can implement to integrate Elasticsearch ?
Any docs etc to point us in the right direction ?
Thanks again

@sebastienros
Copy link
Member Author

@mickdelaney no special interface, just copy paste the lucene module and adapt to use elasticsearch instead.
Many things will be the same, like the index management, or search page, or queries. They could collide if they are enabled at the same time, but they are not supposed to be.
Feel free to ask questions on gitter or join the triage meetings when you are stuck.

@Sen-Gupta
Copy link

Sen-Gupta commented Mar 7, 2021

@sebastienros @jtkech @deanmarcussen @hishamco

We have implemented ElasticSearch (Basics in place), Index(Create, Delete, Rebuild), Indexing and Query using DSL.
Both (Elastic and Lucene can co-exist) ;-)

There are couple of observations, though

  1. Lucene Content Search Picker should be better named as "Search Content Picker"? and the result provide must be abstracted higher.
  2. The queries module is wired to be a sub node of Lucene Search Module
    So we can only see queries module when Lucene is enabled.

Please guide how to proceed on this.

The implementation is very basic/raw but does what is intended.

@jtkech
Copy link
Member

jtkech commented Mar 7, 2021

@Sen-Gupta Cool !

@Skrypt is better placed to give you some feedbacks, as he is the Lucene expert

Anyway, feel free to open a PR with your suggested code

@Skrypt
Copy link
Contributor

Skrypt commented Mar 9, 2021

Well, first thing is to have a branch or PR to work with. Then, we can make the changes in that branch if needed.

@giannik
Copy link
Contributor

giannik commented Apr 3, 2021

@Sen-Gupta is there a public repo to try out the elastic search module ?

@Sen-Gupta
Copy link

Sen-Gupta commented Apr 5, 2021

@giannik This should be pushed potentially tomorrow! Been stuck on another Solr Search Implementations!
This works but is just the starting point!

@Sen-Gupta
Copy link

The PR can be seen here #9108

@yash1529
Copy link

Can u make a tutorial for a step by step how to enable elastic search for orcahrd core? I am not able to enable elastic search UI on my admin interface

@Piedone
Copy link
Member

Piedone commented Apr 20, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet