Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any posibility to send attachments with email in email activity in workflow ? #5108

Open
MuhammadTalha10 opened this issue Dec 23, 2019 · 19 comments

Comments

@MuhammadTalha10
Copy link

No description provided.

@MuhammadTalha10
Copy link
Author

I have a job form and it contain candidate CV in pdf form how do I can send that pdf through email to the recipient email address? or is there any other way to do this ?

@hishamco
Copy link
Member

The current email abstraction APIs doesn't support sending an attachment file, but we could add this feature in the future releases

@MuhammadTalha10
Copy link
Author

any other solution for this ? what should you propose ?

@hishamco
Copy link
Member

M suggestion is to create a new implementation of ISmtpService which support sending attachments, you could have a look to the current SmtpService implementation if you do so

@sebastienros sebastienros added this to the 1.0.x milestone Dec 26, 2019
@sebastienros
Copy link
Member

First we need a task to extract files from POST requests. Then save it temporarily and then another task that could join files to emails.

@Greg712144
Copy link

Hello All,

I'm running into the same issue now even two years later as I am just learning about using the workflow activities. Has there been any update on this? I mean in regards to adding the attachment feature.

@MikeKry
Copy link
Contributor

MikeKry commented Aug 17, 2022

I would also welcome this feature.

imho related to #6027
should be enough to finish save files task, add their paths to output and create input in send email task that would consume list of files and send them as attachments.

@MikeKry MikeKry mentioned this issue Aug 18, 2022
6 tasks
@MikeKry
Copy link
Contributor

MikeKry commented Aug 18, 2022

I need it for my project anyway, so I created a POC for OC too. #12218

@sebastienros
Copy link
Member

We need a different issue to track adding an API in the email service to send file.

@MikeKry I believe that this PR is adding support to send files to a workflow and store them, which is a different step.

@hishamco
Copy link
Member

@sebastienros we already support attachments in OC.Email, what API you refer to above?

@sebastienros
Copy link
Member

@hishamco my bad then, it's just about the workflows.

@sebastienros
Copy link
Member

Which means what @MikeKry did is the good first task, support file uploads in workflows. Next step would then be to be able to attach one of these files in an email task. Or another file that is not coming from the workflow (media).

@hishamco
Copy link
Member

I'm still suggesting to rid-off media abstractions in OC.Email, just extract the posted file and download it temparory using OC.FileSystem APIs as @sebastienros suggested earlier

@MikeKry
Copy link
Contributor

MikeKry commented Aug 26, 2022

@sebastienros @hishamco

I confirm that email API already can send attachments.

Mentioned PR handles attachment downloading to FileSystem and also handles attaching them to Email Task and sending via email.

But it should be reviewed if it is safe and if it fits OC architecture.

@hishamco
Copy link
Member

My concern here to remove the dependency on media APIs and follow what described above

@Abhi441
Copy link

Abhi441 commented Oct 21, 2023

can you assign issue to me

@hishamco
Copy link
Member

@Abhi441 if you want to work on this, feel free to send a PR

@Abhi441
Copy link

Abhi441 commented Oct 21, 2023

can you connect for giving kt on issue and application .

@hishamco
Copy link
Member

I didn't understand your question?!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants