Make NullStringLocalizer & HtmlLocalizer Public #10939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Skrypt could you please have a look if you have a time, seems Seb is quite busy ;) |
Skrypt
reviewed
Feb 1, 2022
|
Ok looks good to me. The only thing I've not looked at is the generic classes utility. Else, this is just some moving around of classes for cleaner overall usage. |
|
@sebastienros could we merge this? |
|
Can we merge this? |
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
hishamco
force-pushed
the
hishamco/null-localizer
branch
from
6d123ae
to
bedba18
Compare
|
This pull request has merge conflicts. Please resolve those before requesting a review. |
|
@Skrypt any other thing to add here or shall I merge? |
Skrypt
reviewed
Feb 3, 2024
src/OrchardCore/OrchardCore/Localization/NullStringLocalizerFactory.cs
Outdated
Show resolved
Hide resolved
Skrypt
reviewed
Feb 3, 2024
src/OrchardCore/OrchardCore.Localization.Abstractions/NullHtmlLocalizerOfT.cs
Outdated
Show resolved
Hide resolved
Skrypt
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solved two issue:
NullStringLocalizerandNullHtmlLocalizerwithout need to use localizer factory, which quite useful in unit testingIStringLocalizer<T>and/orIHtmlLocalizer<T>testable without using mocksOrchardCore.Localization.Abstractionsis a suitable place for such types, something similiar toNullLoggerNo breaking-changes here,
NullStringLocalizerFactoryandNullHtmlLocalizerFactoryare still using the above types without any issues