Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop netcore 3.1 and net 5 #10979

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Drop netcore 3.1 and net 5 #10979

merged 2 commits into from
Jan 7, 2022

Conversation

deanmarcussen
Copy link
Member

@agriffard your other pr regarding the templates and upgrading to program.cs should remain, we will just need to fix the NLog issue

@hishamco
Copy link
Member

hishamco commented Jan 7, 2022

Why we need to drop NetCore 3.1 while still LTS, If I'm not wrong it will be out of support in March. Is there any reason for this change?

@Skrypt
Copy link
Contributor

Skrypt commented Jan 7, 2022

Then stay on 1.2 if you need netcoreapp3.1
Else, the next release of OC will be only in a few months which should drop support for netcoreapp3.1
So, it is fine that the main branch which will feed the preview Nuget packages drops it before time.
It gives time for people to adjust accordingly.

@hishamco
Copy link
Member

hishamco commented Jan 7, 2022

Thanks for clarification

@@ -38,7 +38,7 @@ Here is a more detailed [roadmap](https://github.com/OrchardCMS/OrchardCore/wiki

- Install the latest version of the .NET SDK from this page <https://dotnet.microsoft.com/download>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we be explicit about the version 6.0 to avoid unexpected things?

@hishamco
Copy link
Member

hishamco commented Jan 7, 2022

Also these should be removed

[Obsolete("This method will be removed in the upcoming ASP.NET Core major release.")]
public IStringLocalizer WithCulture(CultureInfo culture) => this;

@Skrypt
Copy link
Contributor

Skrypt commented Jan 7, 2022

Obsolete code should be removed before the next release; this is not a concern for this PR if it doesn't break the build.

@hishamco
Copy link
Member

hishamco commented Jan 7, 2022

@Skrypt this not OC specific, It's deprecated by ASP.NET Core at the time, we kept there to support multi-targeting

@deanmarcussen
Copy link
Member Author

Also these should be removed

Yes, however there will be other things as well.
Can be done seperately as we find them.

@sebastienros
Copy link
Member

@Skrypt anything to do for the vscode launch files?

@Skrypt
Copy link
Contributor

Skrypt commented Jan 7, 2022

It's already set to net6.0 so it should work fine.

@sebastienros sebastienros merged commit acce79a into main Jan 7, 2022
@sebastienros sebastienros deleted the deanmarcussen/dropoldnets branch January 7, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants