-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop netcore 3.1 and net 5 #10979
Drop netcore 3.1 and net 5 #10979
Conversation
Why we need to drop NetCore 3.1 while still LTS, If I'm not wrong it will be out of support in March. Is there any reason for this change? |
Then stay on 1.2 if you need netcoreapp3.1 |
Thanks for clarification |
@@ -38,7 +38,7 @@ Here is a more detailed [roadmap](https://github.com/OrchardCMS/OrchardCore/wiki | |||
|
|||
- Install the latest version of the .NET SDK from this page <https://dotnet.microsoft.com/download> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we be explicit about the version 6.0 to avoid unexpected things?
Also these should be removed Lines 81 to 82 in 0664716
|
Obsolete code should be removed before the next release; this is not a concern for this PR if it doesn't break the build. |
@Skrypt this not OC specific, It's deprecated by ASP.NET Core at the time, we kept there to support multi-targeting |
Yes, however there will be other things as well. |
@Skrypt anything to do for the vscode launch files? |
It's already set to net6.0 so it should work fine. |
@agriffard your other pr regarding the templates and upgrading to program.cs should remain, we will just need to fix the NLog issue