Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orchard Framework -> Orchard Core #11040

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Orchard Framework -> Orchard Core #11040

merged 3 commits into from
Jan 20, 2022

Conversation

hishamco
Copy link
Member

No description provided.

hishamco
hishamco commented Jan 19, 2022
View reviewed changes
src/OrchardCore.Themes/TheTheme/Views/Home/Index.cshtml
@@ -1,3 +1,3 @@
<div class="message message-success">
<h4>@T["Welcome to the Orchard Framework, your site has been successfully set up."]</h4>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing while the Orchard Framework is a set of APIs that could be used in Orchard Core CMS and any other app

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Orchard Core. You can drop the "the".

@agriffard
Copy link
Member

the Orchard Core => Orchard Core
as The Facebook became Facebook ;-)

@hishamco
Copy link
Member Author

We already use Orchard Core in the dashboard as CMS, but when I saw this in SAAS I felt it's weird

@agriffard
Copy link
Member

agriffard commented Jan 19, 2022 •
edited
Loading

drop the "the"
The day I can pronounce this sentence properly, I'll consider myself as an English speaker.

@agriffard
Copy link
Member

https://translate.google.com/?sl=en&tl=fr&text=drop%20the%20%22the%22&op=translate

@hishamco
Copy link
Member Author

J'ai laissé tomber le "le" :)

@hishamco
Copy link
Member Author

Believe it or not I didn't see "The" before ;) seems because I have a cold ;)

@Skrypt
Copy link
Contributor

Skrypt commented Jan 20, 2022

le le de de 😄

@Skrypt Skrypt merged commit 7ea20ad into main Jan 20, 2022
@Skrypt Skrypt deleted the hishamco/typo branch January 20, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skrypt Skrypt Skrypt left review comments

@sebastienros sebastienros sebastienros approved these changes

@agriffard agriffard Awaiting requested review from agriffard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hishamco @agriffard @Skrypt @sebastienros