Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NULL indexed value for LocalizationSetContentPickerFieldIndexHandler #11249

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

Skrypt
Copy link
Contributor

@Skrypt Skrypt commented Feb 22, 2022

Fixes #11248

See ContentPickerFieldIndexHandler (same principle) :

if (field.ContentItemIds.Length > 0)
{
foreach (var contentItemId in field.ContentItemIds)
{
foreach (var key in context.Keys)
{
context.DocumentIndex.Set(key, contentItemId, options);
}
}
}
else
{
foreach (var key in context.Keys)
{
context.DocumentIndex.Set(key, "NULL", options);
}
}

@Skrypt Skrypt requested a review from jptissot February 22, 2022 18:53
@Skrypt Skrypt merged commit 5ade162 into main Feb 22, 2022
@Skrypt Skrypt deleted the skrypt/#11248 branch February 22, 2022 19:44
@Piedone
Copy link
Member

Piedone commented Feb 22, 2022

Probably my worst contribution ever to add Media indexing, it'll continue to haunt me forever :D.

@Skrypt
Copy link
Contributor Author

Skrypt commented Feb 22, 2022

Don't worry it is @jptissot fault on that one 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalizationSetContentPickerFieldIndexHandler is not indexing NULL values
3 participants