Ignore IUpdateModel and BuildPartDisplayContext in console_log #11286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +16,8 @@ public class BagPartEditViewModel | |||
| [BindNever] | |||
| public BagPart BagPart { get; set; } | |||
|
|
|||
| [System.Text.Json.Serialization.JsonIgnore] | |||
There was a problem hiding this comment.
Isn't there a common attribute that doesn't require referencing these libraries?
There was a problem hiding this comment.
I added as - I guess NewtosoftJson's JsonIgnore wont work for System.Text.Json
There was a problem hiding this comment.
[IgnoreDataMember], or [NonSerialized] might work for both libraries
There was a problem hiding this comment.
@sebastienros NonSerialized is not allowed on properties
However IgnoreDataMember is working - Updated the PR
|
@sebastienros @deanmarcussen It's be nice to have this included in 1.4 |
deanmarcussen
approved these changes
May 12, 2022
Skrypt
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore
IUpdateModelandBuildPartDisplayContextproperties in console_log for Shape jsonFixes #11260