Remove Lucene from built-in recipes (Lombiq Technologies: OCORE-84) #11328
Conversation
|
Two tests don't work anymore because the base Blog recipe doesn't contain Lucene anymore. What should I do with them? Can I delete them? |
|
The tests need to be kept but modify them that they can utilize the new factored out recipes. |
src/OrchardCore.Themes/TheBlogTheme/Recipes/blog.lucene.setup.recipe.json
Outdated
Show resolved
Hide resolved
src/OrchardCore.Themes/TheBlogTheme/Recipes/blog.lucene.setup.recipe.json
Outdated
Show resolved
Hide resolved
src/OrchardCore.Themes/TheBlogTheme/Recipes/blog.lucene.recipe.json
Outdated
Show resolved
Hide resolved
src/OrchardCore.Themes/TheBlogTheme/Recipes/blog.lucene.query.recipe.json
Show resolved
Hide resolved
Co-authored-by: Zoltán Lehóczky <[email protected]>
|
Could you please also do a review now, @Skrypt? |
Co-authored-by: Zoltán Lehóczky <[email protected]>
|
I will do it tomorrow. |
|
Thanks! |
| @@ -44,6 +44,7 @@ public async Task ExecuteAsync(RecipeExecutionContext context) | |||
| { | |||
| luceneIndexSettings.Value.IndexName = luceneIndexSettings.Key; | |||
| await _luceneIndexingService.CreateIndexAsync(luceneIndexSettings.Value); | |||
| await _luceneIndexingService.ProcessContentItemsAsync(luceneIndexSettings.Key); | |||
There was a problem hiding this comment.
This can cause a request timeout which is why it was not added. In this case, if the recipe fails to execute then executing it a second time would probably not work.
There was a problem hiding this comment.
It should be a fire and forget type of execution here. Start the indexing background task for example.
|
Can you assert that the IndexingTask table has records before executing the recipes? Else, we will need a method to resync the already created content items in that table. |
|
You mean before running the new Lucene recipe, right? I can see a few records here. I am not sure if this is what you wanted to see.
|
|
Ok, this works with TheBlog recipe because we enable the Lucene feature from the setup. But let's say we do the same but with the SaaS recipe then. I'm pretty sure that the IndexingTask table will not be there. So, if we create content items before enabling the Lucene feature then these content items will not be added to the IndexingTask table. I'm ok to merge the current PR as is since this is a known issue that needs to be fixed. But we could fix it with a different PR. |
Fixes #11203