Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lucene query docs, fixing QueryStringQueryProvider (Lombiq Technologies: OCORE-93) #11561

Merged
merged 9 commits into from
Apr 22, 2022

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Apr 19, 2022

Fixes #11560.

This contribution is sponsored by the City of Santa Monica.

@Piedone Piedone requested a review from agriffard as a code owner April 19, 2022 18:37
@Skrypt
Copy link
Contributor

Skrypt commented Apr 19, 2022

Ok, I need to review both of these first :

https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html
https://lucene.apache.org/core/2_9_4/queryparsersyntax.html

Need to see if the first one is equivalent or not. We need to try to follow ElasticSearch documentation/implementation.

Else, good work. 😄

@Piedone
Copy link
Member Author

Piedone commented Apr 19, 2022

While I didn't know about it up until now, this is pretty much a simplified Query string query indeed.

Thanks :).

@Piedone Piedone changed the title Parsed Lucene query provider (Lombiq Technologies: OCORE-93) Lucene query docs, fixing QueryStringQueryProvider (Lombiq Technologies: OCORE-93) Apr 21, 2022
@Piedone Piedone changed the title Lucene query docs, fixing QueryStringQueryProvider (Lombiq Technologies: OCORE-93) Lucene query docs, fixing QueryStringQueryProvider (Lombiq Technologies: OCORE-93) Apr 21, 2022
@Piedone
Copy link
Member Author

Piedone commented Apr 21, 2022

Updated according to what was discussed under the issue.

Copy link
Contributor

@Skrypt Skrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me. We should take a second look at the MultiFieldParser later on if it is required but I believe that the SimpleQueryStringQuery should cover that use case.

@Piedone Piedone merged commit c6d8d64 into OrchardCMS:main Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsed Lucene query provider
2 participants