-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lucene query docs, fixing QueryStringQueryProvider (Lombiq Technologies: OCORE-93) #11561
Conversation
Ok, I need to review both of these first : https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html Need to see if the first one is equivalent or not. We need to try to follow ElasticSearch documentation/implementation. Else, good work. 😄 |
While I didn't know about it up until now, this is pretty much a simplified Query string query indeed. Thanks :). |
Updated according to what was discussed under the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me. We should take a second look at the MultiFieldParser later on if it is required but I believe that the SimpleQueryStringQuery should cover that use case.
Fixes #11560.
This contribution is sponsored by the City of Santa Monica.