Fix some bootstrap 5 left after migration from bootstrap 4 #11683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling new updates
MikeAlhayek
changed the title
|
@sebastienros @kevinchalet can these changes be part of the 1.4 release please? |
@CrestApps how it was before? |
Skrypt
reviewed
May 12, 2022
@hishamco here is how it was
|
sebastienros
approved these changes
May 12, 2022
hishamco
reviewed
May 12, 2022
| buttonTag.InnerHtml.Append(shape.Grouping.Key); | ||
| headerTag.InnerHtml.AppendHtml(buttonTag); | ||
| var buttonIconTag = new TagBuilder("i"); | ||
| buttonIconTag.AddCssClass("fa-solid fa-angle-down"); |
There was a problem hiding this comment.
Could we remove the extra lines here?
hishamco
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are could missed classes after migrating BS 4 to 5.
Also, slightly improve the Card shape to look like this. Red arrow point to the minor changes