Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LiquidPart models to abstractions #11722

Closed

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented May 17, 2022

Move LiquidPart models to abstractions and update find name to match the class name

@hishamco
Copy link
Member

Just a quick comment not related to the PR, why I see many commits everytime when you push a PR, could you please rebase on main branch, then push your commits

@MikeAlhayek
Copy link
Member Author

@hishamco i’ll research how to rebase.

@hishamco
Copy link
Member

If you have a Git client such as GitHub client or Fork you can easily select the branch, right click then rebase

@sebastienros
Copy link
Member

We don't put parts in abstractions, and we don't want Liquid abstractions to reference Content Management.

Maybe you are looking for something like an Aspect to put in abstractions (c.f. IBodyAspect). Can you explain your use-case?

@MikeAlhayek
Copy link
Member Author

If you have a Git client such as GitHub client or Fork you can easily select the branch, right click then rebase

@hishamco I don't think I can do rebase. maybe I am not following a specific workflow. but here is what I typically do.

  1. I have a never changing main branch which is the original fork. This branch will always be 1:1 with OrchardCore:main. this should prevent any conflicts
  2. Start a new feature branch from my main branch.
  3. Make all my changed to the feature branch
  4. Create a PR

If I rebase my feature branch into my master, now my main/master branch will be different from OrchardCore:main.

Let me know if there is a better more recommended approach to follow

@hishamco
Copy link
Member

Do you have a Git client or you are working from CMD? Please try "Fork" it's simple and easy Git client that can simplify the Git stuff from the UI

@MikeAlhayek MikeAlhayek deleted the MoveLiquidModelsToAbstractions branch May 25, 2022 02:48
@MikeAlhayek
Copy link
Member Author

@hishamco I use Visual Studio 2022 to do git commands. I don't know what is the recommended workflow but the workflow I am using is stated above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants