-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move LiquidPart models to abstractions #11722
Move LiquidPart models to abstractions #11722
Conversation
pulling new updates
Just a quick comment not related to the PR, why I see many commits everytime when you push a PR, could you please rebase on |
@hishamco i’ll research how to rebase. |
If you have a Git client such as GitHub client or Fork you can easily select the branch, right click then rebase |
We don't put parts in abstractions, and we don't want Liquid abstractions to reference Content Management. Maybe you are looking for something like an Aspect to put in abstractions (c.f. IBodyAspect). Can you explain your use-case? |
@hishamco I don't think I can do rebase. maybe I am not following a specific workflow. but here is what I typically do.
If I rebase my feature branch into my master, now my main/master branch will be different from OrchardCore:main. Let me know if there is a better more recommended approach to follow |
Do you have a Git client or you are working from CMD? Please try "Fork" it's simple and easy Git client that can simplify the Git stuff from the UI |
Move LiquidPart models to abstractions and update find name to match the class name