Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Scripting docs to reflect the correct way to use IScriptingManager and IScriptingEngine #11829

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Update the Scripting docs to reflect the correct way to use IScriptingManager and IScriptingEngine #11829

merged 2 commits into from
Jun 9, 2022

Conversation

MikeAlhayek
Copy link
Member

Fix #11814

@MikeAlhayek MikeAlhayek mentioned this pull request Jun 8, 2022
Closed
@hishamco
Copy link
Member

hishamco commented Jun 8, 2022

BTW finally I see 1 commit instead of +10 ;)

@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Jun 8, 2022 •
edited
Loading

BTW finally I see 1 commit instead of +10 ;)

This was by far harder than the commit in this PR :). Glad this is fixed

@sebastienros sebastienros merged commit dd4385b into OrchardCMS:main Jun 9, 2022
@MikeAlhayek MikeAlhayek deleted the FixHowScriptIsExecutedFromCodeDocs branch September 2, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamco hishamco hishamco approved these changes

@agriffard agriffard Awaiting requested review from agriffard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executing some script docs is outdated
3 participants
@MikeAlhayek @hishamco @sebastienros