Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ContainedStereotypes BagPartSettings to allow a user to include content-types by steryotype #11978

Merged
merged 9 commits into from
Aug 18, 2022
Merged

Add ContainedStereotypes BagPartSettings to allow a user to include content-types by steryotype #11978

merged 9 commits into from
Aug 18, 2022

Conversation

MikeAlhayek
Copy link
Member

@MikeAlhayek MikeAlhayek commented Jul 9, 2022 •
edited
Loading

Fix #11977

Here is a visual of how the edit view of the bag part.

bagpart settings

@MikeAlhayek MikeAlhayek mentioned this pull request Jul 19, 2022
Closed
@MikeAlhayek MikeAlhayek mentioned this pull request Aug 6, 2022
Merged
@MikeAlhayek
Copy link
Member Author

MikeAlhayek commented Aug 11, 2022 •
edited
Loading

This PR is also related to PR #11978

hishamco
hishamco requested changes Aug 15, 2022
View reviewed changes
Copy link
Member

@hishamco hishamco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except few comments

src/OrchardCore.Modules/OrchardCore.Flows/Views/BagPartSettings.Edit.cshtml Outdated Show resolved Hide resolved
...hardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Models/ContentTypeExtensions.cs Show resolved Hide resolved
...hardCore/OrchardCore.ContentManagement.Abstractions/Metadata/Models/ContentTypeExtensions.cs Show resolved Hide resolved
@sebastienros
Copy link
Member

Let's try to not use jQuery anymore when not necessary since BS5 is not using it. And remove it piece by piece.

@hishamco
Copy link
Member

Let's try to not use jQuery anymore when not necessary since BS5 is not using it. And remove it piece by piece.

Is this mean we will remove the jQuery dependency from everywhere?

@sebastienros sebastienros merged commit c13ef60 into OrchardCMS:main Aug 18, 2022
@Skrypt
Copy link
Contributor

Skrypt commented Aug 19, 2022

Is this mean we will remove the jQuery dependency from everywhere?

Yes, at some point. But we are not there yet. We don't encourage using it in the meantime.

@hishamco
Copy link
Member

I never mind, but we could introduce a helper function to reduce of amount code needed for basic stuff

@Skrypt
Copy link
Contributor

Skrypt commented Aug 19, 2022

That would be equivalent to using JQuery right? I have no issue with JQuery but JQueryUI is what we need to get rid of. And at the same time, I don't see any issue using plain javascript.

@hishamco
Copy link
Member

That would be equivalent to using JQuery right?

Right

I don't see any issue using plain javascript

Me too except a lot of code to do a small thing ;)

@MikeAlhayek MikeAlhayek deleted the AddContainedStereotypesToBagPartSettings branch September 2, 2022 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtkech jtkech jtkech left review comments

@hishamco hishamco hishamco requested changes

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ContainedStereotypes BagPartSettings to allow a user to include content-types by steryotype
5 participants
@MikeAlhayek @sebastienros @hishamco @Skrypt @jtkech