Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the logo of the Chinese community as a local file (Lombiq Technologies: OCORE-99) #12039

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Jul 19, 2022

...because including remote images is impolite to the one hosting the image, and a security issue.

@Piedone Piedone requested a review from agriffard as a code owner July 19, 2022 19:50

中文资源

[![Orchard Core CN 中文讨论组](https://pub.idqqimg.com/wpa/images/group.png)](//shang.qq.com/wpa/qunwpa?idkey=48721591a71ee7586316604a7a4ee99d26fd977c6120370a06585085a5936f62)
[![Orchard Core CN 中文讨论组](https://docs.orchardcore.net/en/latest/docs/assets/images/orchard-core-cn-community-logo.png)](https://shang.qq.com/wpa/qunwpa?idkey=48721591a71ee7586316604a7a4ee99d26fd977c6120370a06585085a5936f62)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work once the PR is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This problem is a bit like the previous jquerycdn problem. The difference is that this image comes from Chinese servers..

🤣

@Piedone
Copy link
Member Author

Piedone commented Jul 19, 2022

FYI @hyzx86.

@Piedone Piedone merged commit ce42f05 into OrchardCMS:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants