Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow invariant type/part definition lookup in ContentDefinitionManager #12102

Merged

Conversation

MikeAlhayek
Copy link
Member

Fix #12101

@ns8482e
Copy link
Contributor

ns8482e commented Aug 7, 2022

Not sure if this request might add breaking changes on instantiating type systems are case sensitive - in C# event and Event can be represented differently and technical names are tied to C# types

@MikeAlhayek
Copy link
Member Author

Not sure if this request might add breaking changes on instantiating type systems are case sensitive - in C# event and Event can be represented differently and technical names are tied to C# types

The line prevent the user from creating the name using UI. The good news is that this isn’t going to be a breaking change. It’s more of making all the rules the same :)

@sebastienros sebastienros merged commit f397ada into OrchardCMS:main Aug 18, 2022
@MikeAlhayek MikeAlhayek deleted the InvariantContentDefinitionManager branch September 2, 2022 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow case insensitive definition lookup in ContentDefinitionManager
4 participants