Can Get Shell By Case Insensitive Name.

[MikeAlhayek]

Fix #12106

@jtkech this PR replaces #12114 as per your request

[jtkech]

@CrestApps

Okay will work on it tomorrow.

Just did some little tweaks locally for the unit tests,

Will push it tomorrow to let you see them.

[hishamco]

@CrestApps why you closed #12114 it is not a good idea to close a PR and replace it unless there's a value. I had seen a lot of comments in the previous one during the review. Hope to consider this next time and thanks again for your contribution

[MikeAlhayek]

I did that based on the request from @jtkech

[hishamco]

I will leave the Shell related stuff to @jtkech, just a little notes about the unit tests

[jtkech]

@hishamco

I already said to @CrestApps that I will update the tests with some suggestions, so maybe was too early to review them. The goal being to keep this PR as clean as possible because it acts on a sensitive area.

Just did some little tweaks locally for the unit tests,
Will push it tomorrow to let you see them.

But that's okay as we still only have 2 files changed, so the PR is still "clean" ;)

I will do my suggestions soon.

Anyway the main point is to make _shellContexts and _shellSettings dictionaries case insensitive, I just need to think about it a little more and if I still think it is safe I will merge it (and if unit tests still pass).

Otherwise will wait for more feedback.

[jtkech]

@CrestApps

I pushed my suggestions, feel free to revert or update what you don't like ;)

[hishamco]

Seems the build is failed

[jtkech]

I saw it, I will fix it

Fail intermitently while running all tests in parallel and only for the Default tenant