Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PagerOptions #12207

Merged
merged 8 commits into from
Aug 17, 2022
Merged

Add PagerOptions #12207

merged 8 commits into from
Aug 17, 2022

Conversation

MikeAlhayek
Copy link
Member

Add PagerOptions options.
Replace ISiteService use when possible by IOptions<PagerOptions>
Removed ISiteService when it's not used.

@jtkech
Copy link
Member

jtkech commented Aug 17, 2022

@CrestApps

So I committed some last tweaks

  • Re-use IShellConfiguration for PagerOptions and also ResourceOptions because both related projects still reference (maybe transitively) OC.Abstractions, so better to use IShellConfiguration.

  • Renamed to PagerOptionsConfiguration and ResourceOptionsConfiguration to follow the naming we use most of the time (not always) for I[Post]ConfigureOptions<>.

  • Commented out the OrchardCore_Navigation example in appsettings.json.

I'm waiting for your review ;)

@Skrypt
Copy link
Contributor

Skrypt commented Aug 17, 2022

Looks good to me by doing a quick vertical check.

@jtkech
Copy link
Member

jtkech commented Aug 17, 2022

Okay cool then ;)

@jtkech jtkech merged commit 7c7727a into OrchardCMS:main Aug 17, 2022
@MikeAlhayek MikeAlhayek deleted the CreatePagerOptions branch September 2, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants