-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move role creation into the recipe instead of feature activation #12510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
added
the
breaking change 💥
Issues or pull requests that introduces breaking change(s)
label
Oct 13, 2022
@sebastienros this is ready for a quick review. |
sebastienros
reviewed
Dec 8, 2022
src/OrchardCore.Modules/OrchardCore.Roles/Services/RoleUpdater.cs
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Dec 8, 2022
This PR breaks the permissions feature. Manually removed permissions are added back when the site restarts. |
@gvkries please open a new issue with steps to reproduce the issue. You can reference this PR in the new issue. |
@MikeAlhayek here: #13024 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12425
@jtkech please check this out when your time permits since we chatted about this in the issue.
Here is a summary of the enhancements this PR brings