Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ILuceneSearchQueryService from OrchardCore.Search.Lucene #12624

Merged
merged 5 commits into from
Oct 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class SearchController : Controller
private readonly LuceneIndexingService _luceneIndexingService;
private readonly LuceneIndexSettingsService _luceneIndexSettingsService;
private readonly LuceneAnalyzerManager _luceneAnalyzerManager;
private readonly Abstractions.ILuceneSearchQueryService _searchQueryService;
private readonly ILuceneSearchQueryService _searchQueryService;
private readonly ISession _session;
private readonly IStringLocalizer S;
private readonly IEnumerable<IPermissionProvider> _permissionProviders;
Expand All @@ -44,7 +44,7 @@ public SearchController(
LuceneIndexingService luceneIndexingService,
LuceneIndexSettingsService luceneIndexSettingsService,
LuceneAnalyzerManager luceneAnalyzerManager,
Abstractions.ILuceneSearchQueryService searchQueryService,
ILuceneSearchQueryService searchQueryService,
ISession session,
IStringLocalizer<SearchController> stringLocalizer,
IEnumerable<IPermissionProvider> permissionProviders,
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace OrchardCore.Search.Lucene.Services
{
public class LuceneSearchQueryService : Abstractions.ILuceneSearchQueryService
public class LuceneSearchQueryService : ILuceneSearchQueryService
{
private readonly LuceneIndexManager _luceneIndexManager;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public override void ConfigureServices(IServiceCollection services)
services.AddSingleton<LuceneAnalyzerManager>();
services.AddScoped<LuceneIndexingService>();
services.AddScoped<IModularTenantEvents, LuceneIndexInitializerService>();
services.AddScoped<Abstractions.ILuceneSearchQueryService, LuceneSearchQueryService>();
services.AddScoped<ILuceneSearchQueryService, LuceneSearchQueryService>();
services.AddScoped<INavigationProvider, AdminMenu>();
services.AddScoped<IPermissionProvider, Permissions>();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
using System.Threading.Tasks;
using Lucene.Net.Search;

namespace OrchardCore.Search.Lucene.Abstractions
namespace OrchardCore.Search.Lucene
{
public interface ILuceneSearchQueryService
{
Expand Down
2 changes: 2 additions & 0 deletions src/docs/releases/1.5.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

* Lucene breaking changes. See [this pull request](https://github.com/OrchardCMS/OrchardCore/pull/11052) for details.

`ISearchQueryService` moved to `OrchardCore.Search.Lucene.Abstractions` module as `ILuceneSearchQueryService`. The `OrchardCore.Search` module now takes into consideration multiple search provider implementations.

## Lucene Migration

Manual migration to get back Lucene Indices Settings, Deployment plans, and Queries. (Reference only)
Expand Down