Don't localize custom errors returned by the userinfo endpoint #12803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinchalet
force-pushed
the
userinfo_error_localization
branch
from
44a6168
to
16d6628
Compare
hishamco
reviewed
Nov 14, 2022
| using OpenIddict.Abstractions; | ||
| using OpenIddict.Server.AspNetCore; | ||
| using OrchardCore.Modules; | ||
| using static OpenIddict.Abstractions.OpenIddictConstants; | ||
|
|
||
| namespace OrchardCore.OpenId.Controllers | ||
| { | ||
| // Note: the error descriptions used in this controller are deliberately not localized as |
There was a problem hiding this comment.
I think we should move this note before setting the description
There was a problem hiding this comment.
We can certainly do that. It's worth noting that AccessController already has the same message at the same place:
If we decide to move it before every returned error, this will result in many copies. Is it fine for you?
Skrypt
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAuth 2.0 specification explicitly requires that errors be composed exclusively of certain US-ASCII characters, which basically prevents localizing them:
It's an issue we identified and fixed some time ago for the errors returned by
AccessController, but not byUserInfoController, that still returns a localized error. E.g in French: