Added /Admin relative URL for admin menu nodes

[vengi83644]

This is a change w.r.t #11189

[vengi83644]

@Skrypt @hishamco @sebastienros

Hi Team, Please check if this can be moved forward.

Thanks,
R. Venkatesan

[hishamco]

Thanks for contribution, first of all please close your PR https://github.com/venbacodes/OrchardCore/pull/1 it's not necessary to submit a PR from your repo, then I will try to have a quick look to your changes

[vengi83644]

@hishamco I just updated the source code to take the prefix from AdminOptions

[hishamco]

No need to ping me again, I'm already get a notification when something updated here ;)

[hishamco]

Just fix a little formatting and it's good for me

[vengi83644]

Thanks @hishamco , @jtkech.

Should I forward this to someone else for merging?

[hishamco]

Thanks for your contribution @vengi83644

[Piedone]

Contrary to the PR's title, this adds /Admin to all menu nodes (built via NavigationManager) that use a relative virtual path (e.g. "~/something"). This effectively makes NavigationManager admin-only. I don't think this was the intention, right?

[jtkech]

@Piedone Oups that's sad, at some point I thought about being able to use a kind of token {admin} so that if it is present it is replaced by the current admin prefix, otherwise it works as before.

If you think that would be a good compromise, you could open an issue that we could fix.

[Piedone]

I think NavigationManager shouldn't be changed, i.e. reverted back. Rather, OrchardCore.AdminMenu should handle what needs to be done to auto-prefix only those menu items that were created via itself. Actually, only LinkAdminNodeNavigationBuilder needs to be affected.

[jtkech]

Good catch! Looks like you are right, I may suggest a PR if I have time.

[jtkech]

I started something, #13943 and #13944

[Piedone]

Thank you!