Remove double database connection validation in setup #12826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in SetupService Removes OrchardCore.Setup.Core dependency on YesSql.Abstractions
|
If you look at the comments it says that it could throw an exception if someone tries to use the same database with the same prefix. This is not something that the DB connection validator will test unless I'm wrong. Maybe it should then. |
|
It's tested by |
|
I'm ok with this as long as we are sure that it is now impossible for the |
|
I wrapped shell descriptor manager initialization into a try/catch so it will always fail gracefully with error feedback in the UI. |
jtkech
approved these changes
Nov 19, 2022
hishamco
changed the title
jtkech
changed the title
agriffard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes double database connexion validation in SetupService as it's already done by
IDbConnectionValidator.ValidateAsync.Removes OrchardCore.Setup.Core dependency on YesSql.Abstractions
Fixes #12825