Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce AddUsers() extension method #12932

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Introduce AddUsers() extension method #12932

merged 1 commit into from
Dec 18, 2022

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Dec 9, 2022

No description provided.

@ns8482e
Copy link
Contributor

ns8482e commented Dec 10, 2022 •
edited
Loading

What's benefit you get with this extension method? Ability to register user services by other modules and not just user module? Don't see any reason why some one do that?

@hishamco
Copy link
Member Author

This is handy if we use OC.Users outside OrchardCore, something similar to AddPortableObjectLocalization which registers the required services

@sebastienros
Copy link
Member

Better convention and not breaking.

@hishamco hishamco merged commit 77b22be into main Dec 18, 2022
@hishamco hishamco deleted the hishamco/users-extension branch December 18, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hishamco @ns8482e @sebastienros @Skrypt